Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request to SamToFastq documentation #1834

Closed
GATKSupportTeam opened this issue Oct 6, 2022 · 3 comments
Closed

Update request to SamToFastq documentation #1834

GATKSupportTeam opened this issue Oct 6, 2022 · 3 comments
Assignees
Labels

Comments

@GATKSupportTeam
Copy link
Collaborator

We would like the SamToFastq tool doc page to be more clear that this tool can take both coordinate and name sorted inputs. There should also be a description that the order of the fastq pairs will be different depending on your input sam sort order. This description is in the GATK forum thread.

This request was created from a contribution made by Jakub Savara on July 24, 2022 10:48 UTC.

Link: https://gatk.broadinstitute.org/hc/en-us/community/posts/7568071901083-SamToFastq-bam-order

--

SamToFastq tool:

Can we use as input coordinate and also name sorted bam?

Thanks.

(created from Zendesk ticket #291776)
gz#291776

@gbrandt6 gbrandt6 added the docs label Oct 6, 2022
@droazen
Copy link
Contributor

droazen commented Nov 15, 2022

@GATKSupportTeam Looking at the code for this tool, it's not clear that it will produce correct output when given coordinate-sorted input -- someone should test to make sure.

@kockan kockan self-assigned this Sep 12, 2023
@kockan
Copy link
Contributor

kockan commented Sep 12, 2023

We are fairly confident that this tool produces correct output when given coordinate-sorted input. We still might want to add a test for completeness (and also update the documentation if this was not clear).

@kockan
Copy link
Contributor

kockan commented Feb 13, 2024

Closed by #1920

@kockan kockan closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants