New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaintedCreature is badly encapsulated #8

Open

btrzcinski opened this issue Mar 21, 2016 · 0 comments

Labels

bug

Owner

btrzcinski commented Mar 21, 2016

It uses protected members, like width/height, which are final for no real reason. It doesn't serve as a good academic example of class design.

width/height should be encapsulated and modifiable
paint should be public, most likely

btrzcinski added a commit that referenced this issue


          #8: Encapsulate width/height correctly

321a2d0

btrzcinski added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment