Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commonTeamRoster is out of date #119

Open
brandly opened this issue Feb 11, 2025 · 1 comment
Open

commonTeamRoster is out of date #119

brandly opened this issue Feb 11, 2025 · 1 comment

Comments

@brandly
Copy link
Contributor

brandly commented Feb 11, 2025

Jrue Holiday is listed on the Bucks, Poole on the Warriors, etc
@brandly
Copy link
Contributor Author

brandly commented Feb 12, 2025

On a similar note, nba.playerIdFromName wouldn't find players like "bronny". I revived this old chat bot recently and implemented a new playerIdFromName here: brandly/hubot-nba@1b13734

It uses the https://www.nba.com/players page which is a Next.js site and has the full NBA roster in a JSON payload sitting in a script tag. Just wanted to share in case it's useful to you! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandly