Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slate-api: right hand column colours #71

Open
imaginator opened this issue Jul 7, 2014 · 5 comments
Open

slate-api: right hand column colours #71

imaginator opened this issue Jul 7, 2014 · 5 comments
Assignees
Labels

Comments

@imaginator
Copy link
Member

colours should be:

  • unselected tab: #C4C8CD
  • selected tab and right hand column background: #E5E9EF (dark to light)

screenshot 2014-07-07 15 37 07

reference
screenshot 2014-07-07 15 41 13

@vitoravelino
Copy link
Contributor

I'd like to show you how it's gonna be if I apply #69, #70 and #71 (this). Are you sure? It doesn't look good imho.

y43mm-jx9xh-

@guilhermesgb
Copy link
Member

I'd keep it without these color changes. Instead I would suggest the focus
be on any changes that make the content easier to read.
On Jul 26, 2014 6:48 PM, "Vítor Avelino" [email protected] wrote:

I'd like to show you how it's gonna be if I apply #69
#69, #70
#70 and #71
#71 (this). Are you
sure? It doesn't look good imho.

[image: y43mm-jx9xh-]
https://cloud.githubusercontent.com/assets/188554/3712344/003d21fc-150e-11e4-8a14-0b7f1f4dbfd8.png


Reply to this email directly or view it on GitHub
#71 (comment)
.

@imaginator
Copy link
Member Author

Changes look good imho :)

@imaginator
Copy link
Member Author

There seems to be some background colour behind the "Posts" title. Is that planned?

@vitoravelino
Copy link
Contributor

Okay, I'll make the changes. It's your call. Maybe the syntax highlighting will be a problem because it's prepared to be used on a dark background.

About the title background, it's been there since always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants