Comments are not created when breaking changes happen

[toshi0607]

Hi! Thank you for useful action! When I try this action, a comment about breaking change is not created though a breaking change is detected. Would you help find the cause?

Settings

  breaking:
    runs-on: ubuntu-22.04
    timeout-minutes: 30
    steps:
      - uses: actions/checkout@v3

      - name: Set up Buf
        uses: bufbuild/[email protected]
        with:
          version: ${{ env.BUF_VERSION }}

      - name: Check breaking changes
        uses: bufbuild/buf-breaking-action@v1
        with:
          input: schema/proto
          against: https://github.com/xxx/yyy.git#branch=main,subdir=schema/proto

Output

Run bufbuild/buf-breaking-action@v1
  with:
    input: schema/proto
    against: https://github.com/xxx/yyy.git#branch=main,subdir=schema/proto
    buf_input_https_username: toshi0607
    buf_input_https_password: ***
  env:
    BUF_VERSION: 1.18.0
Error: Previously present field "[3](https://github.com/xxx/yyy/actions/runs/nnnn/jobs/mmmm#step:4:3)" with name "request_time" on message "HelloResponse" was deleted.
Error: buf found 1 breaking changes.

[timostamm]

Hey @toshi0607,

I set up the action in a test repository and opened a PR with a breaking change. On the "Files changed" tab on the PR, I see an annotation right next to the line where the change was made:

I tested it with the most recent version of the buf setup action as well, and the result was the same.

[timostamm]

My setup is equivalent to yours, including the subdirectory provided in the input and in the git URL.

The only thing that seems odd to me from your information is the line:

Error: Previously present field "[3](https://github.com/xxx/yyy/actions/runs/nnnn/jobs/mmmm#step:4:3)" with name "request_time" on message "HelloResponse" was deleted.

I wouldn't expect a link in the error message - rather just the field number, like so:

Error: Previously present field "3" with name "request_time" on message "HelloResponse" was deleted.

If this wasn't a copy&paste gone bad, can you isolate this to a change in a specific proto file?

[chrispine]

I'm going close this issue, but feel free to re-open if needed!