Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path not exist errors from allowNotExist check shows root relative paths instead of relative paths to working directory #708

Closed
doriable opened this issue Nov 5, 2021 · 2 comments
Labels
Bug Something isn't working

Comments

@doriable
Copy link
Member

doriable commented Nov 5, 2021

Currently, when we do checks for allowNotExist for paths provided through the --path and --exclude-path flags, we only print out the root relative path, example:

return nil, fmt.Errorf("path %q has no matching file in the module", potentialDirPath)

We should be printing out the path relative to the user's working directory for more clarity in debugging.

@doriable doriable added Bug Something isn't working P2 labels Nov 5, 2021
@doriable
Copy link
Member Author

doriable commented Jan 4, 2022

Along the same lines, when we are returning errors to users around imports, we should indicate that in the error: bufbuild/buf-lint-action#10

@bufdev
Copy link
Member

bufdev commented Jan 4, 2022

I don't believe this path will necessarily be relative to a user's working directory - this could be within a tarball, git repo, etc.

@bufdev bufdev removed the P2 label Feb 2, 2023
@bufdev bufdev closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants