Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google.type.(date|datetime|timeofday) #227

Open
derekperkins opened this issue Sep 8, 2022 · 2 comments
Open

Support google.type.(date|datetime|timeofday) #227

derekperkins opened this issue Sep 8, 2022 · 2 comments

Comments

@derekperkins
Copy link

derekperkins commented Sep 8, 2022

There is already native helper support for google.protobuf.Timestamp, and while google.type.* aren't WKTs, they're pretty close. Since it will all be coerced to a JS Date, similar helpers could be provided for these three types.

cc @tannerlinsley

@timostamm
Copy link
Member

Thanks for the request, Derek, also for the related #226.

Conversion between DataTime and a JavaScript Date object might be the lowest hanging fruit here, although it may be non-trivial to support IANA timezones (the only standard API is buried in Intl.DateTimeFormat).

@xmlking
Copy link

xmlking commented Oct 29, 2022

I also shared the inconsistent behavior when using google.type.*

connectrpc/connect-es#262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants