Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow s390x arch #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow s390x arch #93

wants to merge 1 commit into from

Conversation

gongsu832
Copy link

Allow rules to be used on s390x arch.

@gongsu832
Allow s390x arch
fd6eb3c 
Signed-off-by: Gong Su <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

srikrsna-buf
srikrsna-buf reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@srikrsna-buf srikrsna-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not work as there is no binary built for s390x architecture. Were you able to test this on that architecture?

@gongsu832
Copy link
Author

Since this is a dependency of protobuf, the patch allows me to build protobuf on s390x successfully which I couldn't otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikrsna-buf srikrsna-buf srikrsna-buf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gongsu832 @CLAassistant @srikrsna-buf