Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make Layer set use "Name" as an attribute not "LayerSetName" #4

Open
Moult opened this issue Feb 22, 2022 · 5 comments
Open

Comments

@Moult
Copy link
Collaborator

Moult commented Feb 22, 2022

Reported https://forums.buildingsmart.org/t/can-we-make-layer-set-use-name-as-an-attribute-not-layersetname/3528

This is one of those things in the codebase I put a comment going "what's going on IFC".

Quoted:

Everything else uses "Name" except for IfcMaterialLayerSet and it's inconsistent :)

@TLiebich
Copy link
Contributor

guess purely a legacy issues. Since attribute namesdo not show up in the exchange file I would opt for renaming it in favor of consistency.

@Moult
Copy link
Collaborator Author

Moult commented Feb 24, 2022

+1. @aothms ? Something to move into the decided phase?

@aothms
Copy link
Collaborator

aothms commented Feb 24, 2022

No particular opinion. It's indeed inconsistent, but changing the name is also somewhat annoying for implementers. I think I'd postpone this to a major release, but I'm also realty really fine to make the change.

@pjanck
Copy link
Contributor

pjanck commented Feb 24, 2022

Since attribute names do not show up in the exchange file I would opt for renaming it in favor of consistency.

That is true, however it does show up in early bind libraries, like the one in TUM OpenInfraPlatform. So I'd agree with

somewhat annoying for implementers. I think I'd postpone this to a major release

@Moult
Copy link
Collaborator Author

Moult commented Feb 24, 2022

Marking as onhold :) After 4.3 we can finally make this change! :D

@Moult Moult added the onhold label Feb 24, 2022
@berlotti berlotti transferred this issue from buildingSMART/IFC4.3.x-development Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants