Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel Objective C versions of iOS functionalities #202

Open
laurisvan opened this issue Mar 24, 2020 · 6 comments
Open

Parallel Objective C versions of iOS functionalities #202

laurisvan opened this issue Mar 24, 2020 · 6 comments
Assignees

Comments

@laurisvan
Copy link

Hi,

Our team needed to have an Objective C version of device calendar (mainly due to build and binary size limitations) of your great plugin. However, maintaining a fork is rarely a good idea, and we would like to get the implementation upstream. As a small added feature from our side, we have added feature for subscribing for calendar changes, so that Flutter side could be notified when events are CRUDed in one of the subscribed calendars.

Our developer @andreychernikovich created such an implementation, and found out a way on hosting two ios implementations within a project. However, some work is needed to get builds work properly, and we would not like to do that if there is no chance of getting the PR accepted.

The question is - would you accept hosting two ios implementations in this project?

@bhl09
Copy link
Contributor

bhl09 commented Mar 29, 2020

Hi,
Currently, our priority is to maintain Swift code but we're happy to review if you'd like to contribute and open a PR for Objective C code.

@nickrandolph
Copy link
Contributor

@andreychernikovich are you still working on this?

@andreychernikovich
Copy link

@nickrandolph yes, today i'm will be fix it

@laurisvan
Copy link
Author

Ping @nickrandolph would you be able to check Andrey's MR - it should be rebased now.

@laurisvan
Copy link
Author

@nickrandolph Don't want to be pushing you, but can you give a quick heads-up on your current status - we all are busy from time to time, but would really appreciate feedback on this MR that is very much needed to take your fine library in use. We'd just like to know if the problem is that you're in hurry right now, or it is also ok to say that this MR is not acceptable and we'd need to fork the library in order to move forward.

@thomassth
Copy link
Contributor

The PR #213 seems to be removing swift and implement Obj-C.

Can we allow both to co-exist? Otherwise a fork might be necessary.

@thomassth thomassth removed the enhancement New feature or request label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants