Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VWAP implementation is of MWAP not VWAP #274

Open
twowheelsoul opened this issue Dec 6, 2021 · 1 comment · May be fixed by #285
Open

VWAP implementation is of MWAP not VWAP #274

twowheelsoul opened this issue Dec 6, 2021 · 1 comment · May be fixed by #285
Labels
bug

Comments

@twowheelsoul
Copy link

Hi ,
First of all, Thank you for putting such a effort to implement TA lib.

Issue:
Approach to calculate VWAP is of MWAP i.e.. average price over a period of time.
VWAP needs to be calculated for intraday only and its period should be 1 for first intraday candle, 2 for 2nd intraday candle n so on.
@lit26
Copy link
Collaborator

lit26 commented Dec 22, 2021

#262 similar issue.

@lit26 lit26 added the bug label Dec 22, 2021
@lit26 lit26 linked a pull request Feb 23, 2022 that will close this issue
Open
@lit26 lit26 linked a pull request Feb 23, 2022 that will close this issue
fix vwap #285
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix vwap bukosabino/ta
2 participants
@lit26 @twowheelsoul