You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be desirable if api call template generation would include handling of "Bad Gateway" (-> retry) and "Not Found" (-> ApiException sub type) such that I don't have to write that boiler plate code for every api call I use myself. Maybe allow the user to install a hook into the api client to evaluate and respond to API responses on a general level.
Also, language and datasource parameters could be set once at the client level, instead of adding those parameters to each single call.
The text was updated successfully, but these errors were encountered:
eve-esi is a low level library.
Retrying requests is beyond the scope of the library.
Specific class for specific error codes is not something we want to do, either. You should instead check the http code and response body of the ApiException, as each endpoint have its own error model.
I think the idea of having the datasource set on the client is good. Not sure about language, as, i don’t think it’s set on all requests? I will have to look into how much work that would require or if it’s already possible with stuff like extra headers.
I had a quick look at ApiClient. Looks like it could be feasible to extend that class and overload a few methods to add the retry behaviour. Similarly, caching hooks could be added around the same parts.
It would be desirable if api call template generation would include handling of "Bad Gateway" (-> retry) and "Not Found" (-> ApiException sub type) such that I don't have to write that boiler plate code for every api call I use myself. Maybe allow the user to install a hook into the api client to evaluate and respond to API responses on a general level.
Also, language and datasource parameters could be set once at the client level, instead of adding those parameters to each single call.
The text was updated successfully, but these errors were encountered: