Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline function calls in tests to prepare for removing some `library(… #234

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Oct 3, 2023

…)` calls.

This PR doesn't do anything, but it will make future PRs cleaner

However, it will error more cleanly if some suggested packages are not installed. (to make modeltime a bit more robust to its Suggests packages)

@olivroy
Copy link
Contributor Author

olivroy commented Oct 3, 2023

@mdancho84 CI Passing. after this is merged, I will be able to fix the actual warnings in the code.

@mdancho84 mdancho84 merged commit 46f31b6 into business-science:master Oct 3, 2023
6 checks passed
@olivroy olivroy deleted the deps branch October 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants