-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS build failed in release mode #866
Comments
I've managed to confirm this and this needs to be fixed in 2 places:
|
hi @ra1nj, the 5.0.0-rc.7 is out which should fix the issue you were having, let me know if this fixes the problem for you so we can close this issue 👍 |
I have upgraded the repack version to 5.0.0-rc.7 and pod install, but still facing the same issue:
It seems that it still using metro as bundler ? |
sorry for an oversight, one thing you have to change in the project is the script for set -e
if [[ -f "$PODS_ROOT/../.xcode.env" ]]; then
source "$PODS_ROOT/../.xcode.env"
fi
if [[ -f "$PODS_ROOT/../.xcode.env.local" ]]; then
source "$PODS_ROOT/../.xcode.env.local"
fi
export CLI_PATH="$("$NODE_BINARY" --print "require('path').dirname(require.resolve('@react-native-community/cli/package.json')) + '/build/bin.js'")"
WITH_ENVIRONMENT="$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="$REACT_NATIVE_PATH/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT $REACT_NATIVE_XCODE" This basically points to RNC CLI explicitly instead of relying on the logic in core - which was broken in RN 76 and doesn't allow for overriding the commands out of the box |
After this change, now is working👍 |
Describe the bug
After upgraded to repack5.0, the debug mode is fine, but once i run the app with release mode, the build is failing:
System Info
.
Re.Pack Version
5.0.rc.2
Reproduction
https://github.com/ra1nj/RepackHost/tree/repack_5.0
Steps to reproduce
Clone reproduce repo and install deps then run in release mode
The text was updated successfully, but these errors were encountered: