Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-4 autoloading #88

Open
dustinleblanc opened this issue Dec 3, 2018 · 3 comments
Open

PSR-4 autoloading #88

dustinleblanc opened this issue Dec 3, 2018 · 3 comments

Comments

@dustinleblanc
Copy link

Hey Folks!

We just pulled this project into a site we're working on and realized that none of the code is namespaced per PSR-4 conventions which makes it a little unconventional to work with. Would you be amenable to a pull-request to move this library over to a full PSR-4 compliant namespacing setup? I believe it shouldn't be too difficult to do as I think there are only a handful of classes here. It may help to promote adoption and make it easier for people to create dependent packages (like a Laravel Package, a Drupal 8 module, etc).

Thanks!

@bertheyman
Copy link

I'd be a fan of these changes. However, CampaignMonitor aren't too quick answering on Github - might be best to also drop their support an email.

@purdy
Copy link

purdy commented Nov 30, 2020

Any traction on this? My Drupal codebase fails code style checks because the classes aren't namespaced.

use CS_REST_Subscribers;

Non-namespaced classes/interfaces/traits should not be referenced with use statements

@purdy
Copy link

purdy commented Nov 30, 2020

BTW, if this is helpful to anyone else, you can surround the use statement with annotations to tell phpcs to ignore it for now:

// @codingStandardsIgnoreStart
use CS_REST_Subscribers;
// @codingStandardsIgnoreEnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants