Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charmcraft publish-lib exits with 0 even if publishing fails #1981

Open
lucabello opened this issue Oct 31, 2024 · 0 comments
Open

charmcraft publish-lib exits with 0 even if publishing fails #1981

lucabello opened this issue Oct 31, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@lucabello
Copy link

lucabello commented Oct 31, 2024

Bug Description

Currently charmcraft publish-lib correctly fails the library push if something's wrong with LIBPATCH (e.g., LIBPATCH is not bumped, going back, etc). However, the exit of the command is always 0.

This is a problem especially in CI, where a "publish libraries" step will never fail (because of the 0 exit code), and thus is undetectable.

To Reproduce

  1. Take a charm library of any charm you own
  2. Modify the LIBPATCH to LIBPATCH-1
  3. Run charmcraft publish-lib on that library
  4. Read the failure message and check the exit code (it will be 0)

Environment

charmcraft 3.2.2.post72+g3a094837 (3.x/edge) (but you can reproduce this with any version)

charmcraft.yaml

-

Relevant log output

-
@lucabello lucabello added the Bug Something isn't working label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant