Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cos integration] Provide relation endpoint as function argument #111

Open
rgildein opened this issue Jul 1, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@rgildein
Copy link
Contributor

rgildein commented Jul 1, 2024

Bug Description

Currently, the endpoint names for relations are defined as constant. e.g. APP_LOGGING, APP_METRICS_ENDPOINT and APP_GRAFANA_DASHBOARD

It would be good if this could be provided as argument for functions. For example, the APP_LOGGING should be the default value for logging endpoint in deploy_and_assert_grafana_agent and assert_logging functions.

To Reproduce

async def test_logging(ops_test):
    """Test logging is defined in relation data bag."""
    app = ops_test.model.applications[GRAFANA_AGENT_APP]
    await assert_logging(app, endpoint="my-logging")

Environment

Juju 3.4
Python 3.10

Relevant Log Output

no-logs

Additional Context

No response

@rgildein rgildein added the bug Something isn't working label Jul 1, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5949.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant