Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to KubernetesResourceHandler to reuse Jinja templates #90

Open
NohaIhab opened this issue Mar 11, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@NohaIhab
Copy link
Contributor

Context

The current implementation of KubernetesResourceHandler has a limitation where using jinja's tags to reference a template from within another template, for example the include tag and the import tag.
With this limitation, we resort to duplicating files as a workaround. See an example in this pr, look at katib-config.yaml.j2 and katib-config-configmap.yaml.j2 in the katib-controller templates.

What needs to get done

  1. Look into the usage of Jinja's tags
  2. Implement this feature in KubernetesResourceHandler
  3. Add an API in the base charm's kubernetes compontent
  4. Write tests for krh and the base charm

Definition of Done

chisme's KubernetesResourceHandler and the base charm's kubernetes component allow reusing of jinja templates, tests included.

@NohaIhab NohaIhab added the enhancement New feature or request label Mar 11, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5441.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant