Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tenacity retries #123

Open
DnPlas opened this issue Sep 18, 2024 · 1 comment
Open

Increase tenacity retries #123

DnPlas opened this issue Sep 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Sep 18, 2024

Context

Most (if not all) of the Jupyter notebooks that are used to test various components use tenacity for retrying different operations:

  1. Assert that the workload succeeded or is running
  2. Assert that the workload is deleted correctly

The problem with this is that the retry time can vary from machine to machine; very constrained machines, or machines behind a proxy, will take longer to create the task, bring the workload Pod up and running, and run until completion. Because of this, the proposal is to make the retries configurable.

What needs to get done

  1. Identify all the places where tenacity retries are used
  2. Make those retries (either the time limit or number of attempts) configurable, for example, passing a flag to the tox command --retries-limit=<number>

Definition of Done

The UATs have a configuration option for increasing or decreasing the retries time or attempts.

@DnPlas DnPlas added the enhancement New feature or request label Sep 18, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6271.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant