Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsetting size property does not change block based volume's sizes #14838

Open
hamistao opened this issue Jan 21, 2025 · 0 comments
Open

Unsetting size property does not change block based volume's sizes #14838

hamistao opened this issue Jan 21, 2025 · 0 comments

Comments

@hamistao
Copy link
Contributor

Summary

Unsetting size never resizes block based volumes filesystem volumes and block type volumes.

This applies both to instance volumes, by unsetting the size on the disk device through lxc config device unset inst root size, and to custom volumes, by unsetting its size property through lxc storage volume unset pool vol size. In both cases, setting such property doesn't resize the volume and only unsets the config key, masking the instance's real size.

Although a logical behavior, this could raise a lot of complexity:

Further more because of the delayed nature of volume resizes when applied to a profile of running instances, this unexpected behaviour would take effect at next reboot, which might be quite a while after the change was made.

For this reason I dont think we should apply this change at this time.

Also, block volumes currently can not be shrunk this would only really be useful in a handful of scenarios. This issue aims to raise discussion on whether we want to keep this behavior or we want to resize volumes in such scenarios. This PR has a proposed method to resize on such cases, assuming we want to go that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant