Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve detection/setting of the PATH environment variable #729

Open
tigarmo opened this issue Oct 9, 2024 · 1 comment
Open

Improve detection/setting of the PATH environment variable #729

tigarmo opened this issue Oct 9, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged

Comments

@tigarmo
Copy link
Collaborator

tigarmo commented Oct 9, 2024

What needs to get done

The current code that prevents empty PATH vars only activates on bare-based rocks; as Cris points out we could improve this to cover any case where the PATH is empty to protect ourselves in the case of future changes or new bases.

Why it needs to get done

The empty PATH is a security vulnerability; generalizing the detection and handling of this case improves the robustness of the code.

@tigarmo tigarmo added enhancement New feature or request good first issue Good for newcomers triaged labels Oct 9, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3558.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged
Projects
None yet
Development

No branches or pull requests

1 participant