Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear if gateway-info is a hard requirement #135

Open
DnPlas opened this issue May 24, 2023 · 0 comments
Open

Unclear if gateway-info is a hard requirement #135

DnPlas opened this issue May 24, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented May 24, 2023

_get_env_vars() calls _get_istio_gateway() which returns the name and namespace of the istio ingress gateway as a string in the namespace/name format. The code suggests that in the case of the latter returning None, _get_env_vars() will not stop its execution, but in _get_istio_gateway() it is suggested that the unit should go to WaitingStatus if the relation with istio-pilot:gateway-info does not exist.

From the code, it is not clear if the gateway-info is a hard requirement that should put the unit into WaitingStatus or even BlockedStatus, the only thing that is clear is that _get_env_vars() won't care if there is information about the gateway and it will just proceed. In the case of the relation not being necessary 100% of the times, I recommend we reflect that in the code (removing the WaitingStatus) and also in the documentation.

@NohaIhab NohaIhab added enhancement New feature or request documentation Improvements or additions to documentation labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants