-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise work done for Seldon Metrics Discovery during Obeservability Workshop #68
Comments
#68 Summary of changes: - Merged metrics-discovery branch created at Observability Workshop. - Modified code to integrate Metrics Endpoints Observer. - Updated libs. Merge remote-tracking branch 'origin/metrics-discovery' into feat-metrics-discovery
#68 Summary of changes: - Initial integration test. - Disable some of integration tests to speed up development.
Currently blocked by COS: require some changes to Prometheus. |
Dec 9, 2022 debug session notes:
I guess, my observer is not even starting because of this.
It does live on pod though, but in different place:
|
@i-chvets I believe this is done, please confirm. |
Merged #94 |
Testing work is still required. Not completed yet. |
Finalise work done for Seldon Metrics Discovery during Obeservability Workshop
Work items are tracked in https://warthogs.atlassian.net/browse/KF-829
Branch: https://github.com/canonical/seldon-core-operator/tree/kf-829-gh68-feat-metrics-discovery
Prometheus deployment https://github.com/canonical/prometheus-k8s-operator
Design
Failure alerts are implemented through integration with Prometheus Charm from Canonical Observability Stack. For metrics provided by models targets can change from model to model and from deployment to deployment. Metrics Endpoint Observer provided by COS is integrated. Updates to targets are handled by Mertics Endpoint Observer and relayed to Prometheus by Seldon Core Operator Charm.
Testing
Resulting deployment should like this:
Deploy model with custom metrics:
Get IP address of model classifier and use it for prediction request:
Request prediction using IP address of model classifier:
Metrics are available at pod's IP address and Prometheus port:
https://<Prometheus-unit-IP>:9090
, select Status->TargetsThe text was updated successfully, but these errors were encountered: