Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rebrand /security/docker-images #14728

Merged

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Feb 10, 2025

Done

  • Apply rebranding for /security/docker-images
  • No changes made to content
  • Figma design

QA

Issue / Card

Fixes WD-12039

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (c48cb25) to head (a7e769a).
Report is 73 commits behind head on feature-security-bubble.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature-security-bubble   #14728   +/-   ##
========================================================
  Coverage                    72.32%   72.32%           
========================================================
  Files                          120      120           
  Lines                         3404     3404           
  Branches                      1174     1174           
========================================================
  Hits                          2462     2462           
  Misses                         917      917           
  Partials                        25       25           

@mattea-turic
Copy link
Collaborator

mattea-turic commented Feb 10, 2025

Thank youu @britneywwc ! Basically perfect <3

For "Our Commitment":

  • I used the wrong copy, so feel free to remove the ipsum text!

For "FAQ on the LTS Docker Image Portfolio":

  • Would it be possible to add in the breaks I have in the figma for the h5 subsections?

Feel free to add a design +1 once you make those changes!

@britneywwc
Copy link
Contributor Author

@akbarkz Thanks, I've addressed your comments and also replaced the existing form with the new form template.

@britneywwc britneywwc merged commit 73ac6eb into canonical:feature-security-bubble Feb 11, 2025
15 checks passed
@britneywwc britneywwc deleted the security-docker branch February 11, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants