-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: /security/cis redesign #14732
feat: /security/cis redesign #14732
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-security-bubble #14732 +/- ##
========================================================
Coverage 72.32% 72.32%
========================================================
Files 120 120
Lines 3404 3404
Branches 1174 1177 +3
========================================================
Hits 2462 2462
Misses 917 917
Partials 25 25 |
2a9bcba
to
74bf728
Compare
ab0c5ed
to
df7fcf8
Compare
Looks good to me, thank you! A couple quick comments but they're more visual- than UX-related, so I'll +1 for UX anyway.
![]() ![]() |
Hi @mtruj013 Thanks for your work! I have a few comments including Elaine's suggestions. (Thanks @eliman11 !!)
Also for this section in the mobile view,
That's all from my side. Thanks again! |
hi @mtruj013 this all looks great, thanks for making the adjustments! I'll add a design +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, left a few questions and some minor suggestions :)
<div class="row--50-50"> | ||
<hr class="p-rule" /> | ||
<div class="col"> | ||
<div class="p-section--shallow"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no shallow section wrapping on design for h2 and p, this can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
73ac6eb
to
4e36f04
Compare
44f669d
to
2a7a565
Compare
Thanks @britneywwc! Could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, looks great! 😄
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-12038