Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply rebranding for /security/oval #14734

Merged

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Feb 11, 2025

Done

  • Rebrand /security/oval based on Design, no changes in copy doc
  • Drive-by: Update /security/docker-images to use p-cta-block classes where necessary
  • Note: Waiting for chart placeholder from design

QA

Issue / Card

Fixes WD-12041

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (a7e769a) to head (01eeb4d).
Report is 76 commits behind head on feature-security-bubble.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature-security-bubble   #14734   +/-   ##
========================================================
  Coverage                    72.32%   72.32%           
========================================================
  Files                          120      120           
  Lines                         3404     3404           
  Branches                      1174     1174           
========================================================
  Hits                          2462     2462           
  Misses                         917      917           
  Partials                        25       25           

@mattea-turic
Copy link
Collaborator

mattea-turic commented Feb 12, 2025

thanks @britneywwc !!

for the hero:

  • logo was a little cut off, so i added a new vers. here

for "How we use Ubuntu OVAL":

  • the button looks to have too much padding(?), causing too much whitespace at the bottom of this section

for "Using Ubuntu’s OVAL data":

  • could you add a <br> after "an" in the h5 "Scanning an Official Cloud Image" pls?

for 'Ubuntu OVAL data parameters":

  • could you add 8px bottom padding (or if it's easier, 24px) to the table, so that the note message (Note: The above parameters...) sits a little lower and doesn't look to be a table row

for "How Ubuntu OVAL data works"

  • i added in the old chart while we wait for the new one to be rebranded!

@mattea-turic
Copy link
Collaborator

All looks good aside from the diagram that I added to the assets server, which for some reason didn't include its container lol. I've added another one here

i'll +1 since this is simple change! :)

Copy link
Member

@immortalcodes immortalcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Suggestion for adding alt text to one of logos.

templates/security/oval.html Outdated Show resolved Hide resolved
@britneywwc britneywwc merged commit 2498097 into canonical:feature-security-bubble Feb 13, 2025
15 checks passed
@britneywwc britneywwc deleted the security-oval branch February 13, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants