-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Apply rebranding for /security/oval #14734
feat: Apply rebranding for /security/oval #14734
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-security-bubble #14734 +/- ##
========================================================
Coverage 72.32% 72.32%
========================================================
Files 120 120
Lines 3404 3404
Branches 1174 1174
========================================================
Hits 2462 2462
Misses 917 917
Partials 25 25 |
thanks @britneywwc !! for the hero:
for "How we use Ubuntu OVAL":
for "Using Ubuntu’s OVAL data":
for 'Ubuntu OVAL data parameters":
for "How Ubuntu OVAL data works"
|
All looks good aside from the diagram that I added to the assets server, which for some reason didn't include its container lol. I've added another one here i'll +1 since this is simple change! :) |
73ac6eb
to
4e36f04
Compare
3c90296
to
8b14bbc
Compare
8b14bbc
to
4243996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Suggestion for adding alt text to one of logos.
2498097
into
canonical:feature-security-bubble
Done
p-cta-block
classes where necessaryQA
Issue / Card
Fixes WD-12041
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines