-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make .toPromise attempt to use default Promise constructor #647
Comments
Have you seen the discussion in the original PR?
#628 (comment)
Basically, I was uncomfortable with writing code that implicitly depends on
a JS feature that doesn't exist in all execution environments without a
proper fallback.
…On Fri, May 11, 2018 at 11:32 AM, Alexandre ***@***.***> wrote:
Hi,
I don't understand what's stopping .toPromise() to try to use the default
Promise constructor if none is passed as argument?
I really think this should be the default behavior.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#647>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGIyZVZVQ-EFWWLjdbNo3OxuMAOBj5u6ks5txb0qgaJpZM4T7u99>
.
|
Hi @vqvu, sorry for the late reply. I understand you avoid default arguments values, though is it still a problem to depend on Promise nowadays? It's standard, widely used and available in most environments. |
IE11 is still a thing, unfortunately :(.
…On Wed, May 23, 2018 at 3:14 AM, Alexandre ***@***.***> wrote:
Hi @vqvu <https://github.com/vqvu>, sorry for the late reply.
I understand you avoid default arguments values, though is it still a
problem to depend on Promise nowadays? It's standard, widely used and
available in most environments.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#647 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGIyZVburVnze8f6bK9oW8u5jhBpQax1ks5t1Rp2gaJpZM4T7u99>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I don't understand what's stopping
.toPromise()
to try to use the default Promise constructor if none is passed as argument?I really think this should be the default behavior.
The text was updated successfully, but these errors were encountered: