fixing compare matching rows for spark compares and SF compare

capitalone · Feb 11, 2025 · 2f6a2ce · 2f6a2ce
1 parent 4ccf73f
commit 2f6a2ce
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/datacompy/snowflake.py b/datacompy/snowflake.py
@@ -546,7 +546,7 @@ def count_matching_rows(self) -> int:
                 " and ".join(conditions)
             ).count()
         else:
-            match_columns_count = 0
+            match_columns_count = self.intersect_rows.count()
         return match_columns_count
 
     def intersect_rows_match(self) -> bool:

diff --git a/datacompy/spark/pandas.py b/datacompy/spark/pandas.py
@@ -490,7 +490,7 @@ def count_matching_rows(self) -> bool:
                 .shape[0]
             )
         else:
-            match_columns_count = 0
+            self.intersect_rows.shape[0]
         return match_columns_count
 
     def intersect_rows_match(self) -> bool:

diff --git a/datacompy/spark/sql.py b/datacompy/spark/sql.py
@@ -556,7 +556,7 @@ def count_matching_rows(self) -> int:
                 " and ".join(conditions)
             ).count()
         else:
-            match_columns_count = 0
+            match_columns_count = self.intersect_rows.count()
         return match_columns_count
 
     def intersect_rows_match(self) -> bool: