fixing compare matching rows for spark compares and SF compare #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaffar
requested review from
fdosani,
ak-gupta,
jdawang and
gladysteh99
as code owners
|
All tests (including SF tests) are passing |
|
@rhaffar do you want to bump the version to |
oops didn't see this notif, thanks for bumping - am I good to merge? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where all columns are join columns and both dataframes are equal,
count_matching_rowsis incorrectly calculated. This fixes this calculation for the affected comparison modules -Spark Sql, Spark Pandas, Snowflake.Closes #377