Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix "," in search result titles of ai-chat #443

Open
2 tasks done
Daniel-Schulz-Private opened this issue Feb 17, 2025 · 1 comment
Open
2 tasks done

Comments

@Daniel-Schulz-Private
Copy link

Daniel-Schulz-Private commented Feb 17, 2025

Browser

Chrome, Safari, Firefox

Package version

0.15.0

React version

^1.66.0

Description

Ideally these titles wouldn't use commas at a all, but I've seen this pop up a few times now where we see , in the search result topic title:
Image

After investigation, the bug is in the ai-chat-component lib.

We can see from the code that it's split by coma when parsing the content. when we provide the URL list we use md format URLs separated by comma. when the title contains a comma the library is unable to handle the list correctly since when it splitted the md format URL is corrupted, for example: some title,some,other,title in this example, we can see when the URL list is handled and splitter by comma the second URL is corrupted as it's splitting the title. To handle that we replace the comma sign with , and that's the reason why we see those , symbols.

Reproduction/example

none

Steps to reproduce

Ask a query for any topic that uses a comma in the title.

Suggested Severity

None

Application/PAL

No response

Code of Conduct

@Daniel-Schulz-Private Daniel-Schulz-Private changed the title [Bug]: Fix "," in search result titles [Bug]: Fix "," in search result titles of ai-chat Feb 17, 2025
@cadano
Copy link

cadano commented Feb 17, 2025

To clarify... the &comma is not in the ai-chat-component the problem is that if a URL contains a comma in the title... the CLABSLinkListElement will not handle the link list correctly as its split by comma.. and in that case the URL list will be corrupted.
For example: [some title](https://someurl.com/),[some,other,title](https://someotherurl.com/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants