Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Notification) Feature flag usage, code tab update #4357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(Notification) Feature flag usage, code tab update #4357

wants to merge 1 commit into from

Conversation

Kritvi-bhatia17
Copy link
Contributor

Closes #4222

Short description

This PR updates the component's Usage and Code tabs with the feature flag code changes for Notification including feature flag information and images.

Changelog

New

Usage:

  • Feature flag tag
  • Content (feature flag section)

Code:

  • Resource card feature flag tag
  • Content (feature flag section)

For ref: Figma file

@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners November 14, 2024 12:39
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 0:44am

aagonzales
aagonzales approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Flags] Notification: add feature flag content to Usage and Code tabs
3 participants
@Kritvi-bhatia17 @aagonzales @laurenmrice