-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added strong PolymorphicProps #18384
feat: Added strong PolymorphicProps #18384
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18384 +/- ##
==========================================
- Coverage 84.17% 84.15% -0.02%
==========================================
Files 408 408
Lines 14435 14437 +2
Branches 4660 4662 +2
==========================================
Hits 12150 12150
- Misses 2120 2122 +2
Partials 165 165 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9b9fa47
Closes #18369
Closes #18370
Closes #18371
Added strong PolymorphicProps for
Tag
,Button
andLink
.Changelog
Changed
Changed the way the PolymorphicProp is validated.
NOTE: The only changes are in the way the
type
Code example
Testing / Reviewing