Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New icon animation: sort ascending, sort descending, sort remove #132

Open
johnbister opened this issue Nov 8, 2022 · 2 comments · May be fixed by #165
Open

New icon animation: sort ascending, sort descending, sort remove #132

johnbister opened this issue Nov 8, 2022 · 2 comments · May be fixed by #165
Assignees
@davidmenendez

Comments

@johnbister
Copy link
Contributor

Name of icon to be animated as shown in Carbon Icon Library:
sort ascending, sort descending, sort remove

Category of icon:
opeations

Team/product requesting:
icon motion group

Contacts:
@kristastarr @johnbister

When is this needed?

  • optional - is there a specific deadline

Additional context

  • optional - is there anything else we should know?
@johnbister johnbister linked a pull request Dec 1, 2022 that will close this issue
Open
@johnbister johnbister self-assigned this Dec 1, 2022
@kristastarr
Copy link
Collaborator

@johnbister, @davidmenendez is going to do these to take some off your plate! 😅
@davidmenendez Since these are related to the other "sort", icons (Caret sort, Chevron sort etc) you can reference the keyframes animations on those for consistency, maybe even re-use some of them directly if you think it looks good

@johnbister
Copy link
Contributor Author

@kristastarr @davidmenendez Hey! Thanks for offering, but I actually tackled these already #165

If you want to do some others, I can put up other issues! Sorry to snag it already if you were looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidmenendez davidmenendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sorts carbon-design-system/icons-motion
3 participants
@davidmenendez @kristastarr @johnbister