Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Remove numba as required dependency #483

Open
lorentzenchr opened this issue Jan 3, 2024 · 3 comments
Open

[MAINT] Remove numba as required dependency #483

lorentzenchr opened this issue Jan 3, 2024 · 3 comments
Assignees

Comments

@lorentzenchr
Copy link

Is your feature request related to a problem? Please describe.
numba is specified as required dependency in requirements.txt, but it does not seem to be used anywhere. As it is a quite heavy dependency and not available on all platforms, could it be considered to be removed?

Describe the solution you'd like
Remove numba as required dependency.

@jbogaardt
Copy link
Collaborator

jbogaardt commented Jan 3, 2024

Hi @lorentzenchr. You're correct that there is no direct dependency on numba, but the package does depend on pydata/sparse which has numba as a hard dependency. Until we move off of sparse, I think we're stuck with numba.

@lorentzenchr
Copy link
Author

If I understand correctly, the sparse package is used to provide the "array_backend" for the triangle data (triangle.values array). How about making the sparse backend optional? (if sparse is installed it works, if not an informed error message is thrown.)

@pbower
Copy link

pbower commented Sep 14, 2024

Hi there,

This is causing compatibility issues, therefore I'm wondering whether it would be ok to bump up the latest version of numba?

It's causing versioning issues as Chainladder is incompatible with Numpy 2.1

So, if one has the latest numpy in the environment / app, which other dependencies often reference, Chainladder is causing issues.

Thanks,
Pete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants