Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update docker machine to allow setting encrypted EBS option #1204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonmcewen
Copy link
Contributor

Description

The latest version of docker-machine allows setting a new option amazonec2-volume-encrypted=true.

This MR could go further and set this option by default, or just be left as a version update to allow users to set this option if required.

Migrations required

No

Verification

Setting the option with the current version causes the runner not to start. With the latest docker-machine version it works.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Hey @jonmcewen! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@jonmcewen jonmcewen changed the title Update docker machine to allow setting encrypted EBS option feat: Update docker machine to allow setting encrypted EBS option Nov 4, 2024
@kayman-mk
Copy link
Collaborator

https://gitlab.com/cki-project/mirror/docker-machine/-/commit/27ff34dcf7a67101c98fa978f63899aca36dc8aa

--amazonec2-volume-encrypted`: Encrypt Amazon EBS volume attached to the instance.
--amazonec2-volume-kms-key`: The KMS Key ID/ARN/Alias to be used to encrypt the volume.

@kayman-mk
Copy link
Collaborator

Great! I was already looking for that option but didn't find it.

As we have the KMS keys, ... available in the module, we should go a little further and pass them to the docker machine. Could you add this please to the PR, @jonmcewen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants