Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract role and instance_profile into separate module #253

Open
DavidGamba opened this issue Sep 9, 2020 · 1 comment
Open

Extract role and instance_profile into separate module #253

DavidGamba opened this issue Sep 9, 2020 · 1 comment
Labels
enhancement 🆕 New feature or request work-in-progress Issue/PR is worked, should not become stale

Comments

@DavidGamba
Copy link
Contributor

The way to have a multiple spot instance types is to use multiple instances of the runner #77
Same if you want multiple availability zones #76

You now have two roles, runners and runners2 (from https://github.com/npalm/terraform-aws-gitlab-runner/blob/develop/examples/runner-public/main.tf).

The problem becomes if you want to give your runners access to ECR for example, you have to give access to multiple Principals.
If you extract the role into a separate module and reuse it, then you only have to add a single principal to your other resources the module is accessing.

They are related in that they are the same runner kind just deployed in another zone or with another instance type to avoid capacity issues.

@kayman-mk
Copy link
Collaborator

I also discovered this after changing to 3 AZs. Wouldn't it be easier to create the role/profile yourself and pass it to the module? Then the module can add the policies needed. @npalm What do you think?

Or even better: Add multi AZ support to the module and handle all the stuff internally.

@kayman-mk kayman-mk added refactor enhancement 🆕 New feature or request and removed refactor labels Jan 1, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Mar 18, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Mar 18, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label May 18, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label May 22, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Jul 22, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Jul 27, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Sep 26, 2023
@kayman-mk kayman-mk removed the stale Issue/PR is stale and closed automatically label Sep 28, 2023
@github-actions github-actions bot added the stale Issue/PR is stale and closed automatically label Nov 28, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 30, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 30, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 30, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 30, 2023
@cattle-ops cattle-ops deleted a comment from github-actions bot Nov 30, 2023
@kayman-mk kayman-mk added work-in-progress Issue/PR is worked, should not become stale and removed stale Issue/PR is stale and closed automatically labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆕 New feature or request work-in-progress Issue/PR is worked, should not become stale
Projects
None yet
Development

No branches or pull requests

2 participants