Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nested files when calculating the total #20

Closed
wants to merge 1 commit into from
Closed

Check for nested files when calculating the total #20

wants to merge 1 commit into from

Conversation

marcospb19
Copy link

Fixes #12

marcospb19
marcospb19 commented May 3, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@marcospb19
Copy link
Author

There is some miscalculation that needs to be fixed in the TriePathNode logic.

@marcospb19 marcospb19 marked this pull request as draft October 4, 2021 22:57
cauebs
cauebs reviewed Oct 5, 2021
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@marcospb19 marcospb19 force-pushed the fixing-total-calculation-#12 branch from 2197511 to 1c5c592 Compare December 5, 2021 19:56
@marcospb19
Ignore nested files when calculating the total
83ee20e 
For the nested files:
 - folder/         (5 MB)
 - folder/big_file (15 MB)

The --total now outputs 15 MB instead of the previous 20 MB, because the
inner file is inside of the folder that was also passed as an argument.

Implemented with the Trie data structure, made of HashMap and PathBufs
that represent each path components of the canonicalized file paths.

Fixes cauebs#12.
@marcospb19 marcospb19 force-pushed the fixing-total-calculation-#12 branch from 1c5c592 to 83ee20e Compare December 6, 2021 00:52
@marcospb19 marcospb19 marked this pull request as ready for review December 6, 2021 00:52
@marcospb19
Copy link
Author

Did the suggestions, and fixed some bugs with the previous Trie implementation.

@marcospb19 marcospb19 closed this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauebs cauebs cauebs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if some paths are contained within others, so as not to count them twice towards the total
2 participants
@marcospb19 @cauebs