You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we keep the observed proportions either as:
An array with shape (n_timepoints, n_variants) or
An array with shape (n_variants, n_timepoints).
The problem is that:
Different submodules use different convention (e.g., quasimultinomial and plotting submodules).
In fact, quasimultinomial submodule uses both conventions simultaneously!
As this is very counterintuitive and can lead to annoying bugs down the line (e.g., when calculating overdispersion), I'm annotating it as bug, rather than refactor.
The text was updated successfully, but these errors were encountered:
Currently, we keep the observed proportions either as:
(n_timepoints, n_variants)
or(n_variants, n_timepoints)
.The problem is that:
As this is very counterintuitive and can lead to annoying bugs down the line (e.g., when calculating overdispersion), I'm annotating it as
bug
, rather thanrefactor
.The text was updated successfully, but these errors were encountered: