Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent shapes of the observed proportions #24

Closed
pawel-czyz opened this issue Nov 14, 2024 · 2 comments · Fixed by #27
Closed

Use consistent shapes of the observed proportions #24

pawel-czyz opened this issue Nov 14, 2024 · 2 comments · Fixed by #27
Assignees
Labels
bug Something isn't working

Comments

@pawel-czyz
Copy link
Member

Currently, we keep the observed proportions either as:

  1. An array with shape (n_timepoints, n_variants) or
  2. An array with shape (n_variants, n_timepoints).

The problem is that:

  1. Different submodules use different convention (e.g., quasimultinomial and plotting submodules).
  2. In fact, quasimultinomial submodule uses both conventions simultaneously!

As this is very counterintuitive and can lead to annoying bugs down the line (e.g., when calculating overdispersion), I'm annotating it as bug, rather than refactor.

@pawel-czyz pawel-czyz added the bug Something isn't working label Nov 14, 2024
@dr-david
Copy link
Collaborator

Indeed. Should we do n_timepoints t_timepoints ?

@pawel-czyz
Copy link
Member Author

@dr-david I'm working on this (but only on the public API), so that we will have more consistent user experience in our notebooks. (Well, the notebook, actually: we now officially support only frequentist_notebook_jax, but we have some notebooks which have not been officially added yet, but implement very nice prototypes.)

The PR will spread across quite many files (what's not great for reviewing, but I don't see another solution) and I hope it'll be ready on Wednesday.

@pawel-czyz pawel-czyz mentioned this issue Nov 19, 2024
4 tasks
@pawel-czyz pawel-czyz linked a pull request Nov 19, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants