Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve p4estindent workflow #100

Open
cburstedde opened this issue Mar 12, 2021 · 2 comments
Open

Improve p4estindent workflow #100

cburstedde opened this issue Mar 12, 2021 · 2 comments
Labels
enhancement upforgrabs Desired functionality, currently unassigned

Comments

@cburstedde
Copy link
Owner

Description

We have the p4estindent script and would make its use safer and more standardized.

Proposed solution

  • Put logic into p4estindent that makes it fail when working directory and git index are not the same.
  • Add a CI job to run p4estindent separately for each source and header file and report missing indentation.
@cburstedde cburstedde added enhancement upforgrabs Desired functionality, currently unassigned labels Mar 12, 2021
@lcw
Copy link
Collaborator

lcw commented Mar 12, 2021

For what it is worth, my current version of the git pre-commit hook that checks to see if a file is indented is here https://github.com/lcw/p4est_occa_tutorial/blob/084c089328819c5c9ebdb6ae90507bfc2a379152/misc/git/hooks/pre-commit

@cburstedde
Copy link
Owner Author

That could be a nice starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement upforgrabs Desired functionality, currently unassigned
Projects
None yet
Development

No branches or pull requests

2 participants