Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split the parser into a lexer/parser #16

Closed
cdepillabout opened this issue May 25, 2017 · 3 comments
Closed

split the parser into a lexer/parser #16

cdepillabout opened this issue May 25, 2017 · 3 comments

Comments

@cdepillabout
Copy link
Owner

I think it would be a little easier to change the parsing code if it was split into a lexer/parser (like most programming languages).

I'm going to add the help-wanted label, but I plan on doing this myself when I get the time.

@cdepillabout
Copy link
Owner Author

I left this as a comment on #9, but I think it is worth posting here as well:

It is possible that all we really need is a lexer, and not a lexer/parser. It might be possible to figure out the output indentation and color based entirely on lexed input instead of fully parsed input.

@andrew-lei
Copy link
Collaborator

Should this be closed?

@cdepillabout
Copy link
Owner Author

Yes, thanks a lot!

This was implemented by @andrew-lei in #37!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants