Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OpenChrom to CDK 2.9 (or better) #15

Open
Tracked by #4
egonw opened this issue Jan 2, 2024 · 7 comments
Open
Tracked by #4

update OpenChrom to CDK 2.9 (or better) #15

egonw opened this issue Jan 2, 2024 · 7 comments
Labels

Comments

@egonw
Copy link
Member

egonw commented Jan 2, 2024

@egonw egonw mentioned this issue Jan 2, 2024
9 tasks
@egonw egonw added the WP2 label Jan 2, 2024
@RvdPloeg
Copy link
Collaborator

Modifications were made in the code of OpenChrom to accept the cdk-2.9 version. Build and install look successful, see pull request OpenChrom/openchrom#577.

@Mailaender
Copy link

Did you address cdk/cdk#1044 (comment) in the latest release?

@Mailaender
Copy link

@RvdPloeg
Copy link
Collaborator

Thanks for bringing cdk/cdk#1044 (comment) to my attention.

@RvdPloeg
Copy link
Collaborator

Great news that you are implementing the cdk-2.9.jar! At the moment there are no new updates and thus you are using the newest version of the cdk.

@Mailaender
Copy link

Mailaender commented Dec 13, 2024

I forgot to bump the version at OpenChrom/openchrom3rdpl@9030d7b the repackaging is a bit tedious. (It doesn't affect anything.)

@egonw
Copy link
Member Author

egonw commented Dec 15, 2024

Did you address cdk/cdk#1044 (comment) in the latest release?

hi @Mailaender, no, I'm afraid not. Thanks for pinging about this. I got stuck at the time with making a test to see if Java packages only occur in only one bundle, and second, the regular 'data' classes already cause problems. I will pick this up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants