-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classic Era spits errors #140
Comments
same problem for me - can you please fix it - this addon is so great and works so perfect with adi bags!!!! |
I don't currently have a classic era character, but I'll see what I can do. If nothing else, you should be able to use a previous version. |
AFAIK, Blizzard changed the Lua API in 1.14.x (Era) to ... Shadowlands(?), introducing the infamous "Backdrop" errors to Era:
The good news is: The BCC version Outfitter-2.0.64.TBC seems to work fine for me. |
I created a new character to test in Classic. There were issues with the some namespace changes (C_Container being a major one). I have a fix I'm testing and hopefully should be available soon. |
Can you test out my draft release from my fork? |
I'am afraid that something went wrong and you rereleased the assets of the (not working) version 3.0.4 from 25 january 2023. |
Was that on login or did you do something specific? |
I have a new release package up. Looks like I didn't package up the branch like I thought. |
I confirm: No Lua errors on login and switching gear while riding works fine. It seems that we have a winner :) |
Now i get errors with ADI bags when i activate the latest Outfitter, now lua error with deactivated outfitter: Message: Interface\AddOns\AdiBags\core\Utility.lua:465: attempt to call field 'GetContainerItemQuestInfo' (a nil value) |
That looks to be an issue with AdiBags not fixing the GetContainerItemQuestInfo call to a C_Container.GetContainerItemQuestInfo call. The change I made took out a bunch of C_Container fixes for things Outfitter didn't use. |
I took another look at the code. The current iteration of my fix ends up being global and affects other addons, instead of local to Outfitter as intended. I'll work on trying to get it localized so it won't affect other addons. |
I worked through the AdiBags call and realized it even has a comment where the error happens:
This is why it's failing. I still needed to fix my scoping issue, but AdiBags still needs to do some checking that the function exists before trying to use it. |
@DeTosc Can you try the newer prerelease? @Dragotex I know AdiBags doesn't work with the fix I'm linking, but it should be better overall. To temporarily fix AdiBags, try adding this in Utility.lua at line 463:
|
https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6.2 seems to work fine for me. |
@GovtGeek thx for your help - seems workaround does its job - no lua errors in the last 3 hours |
Adding the line at 463 in Adibags solved the issue :) |
@DeTosc I moved some stuff around under the covers in a new release. Can you try it out to make sure I didn't break something else? @Dragotex @Shamatix Glad I could help. I posted the fix on the AdiBags issue too. |
Well, first of all, outfitter is not considering the settings. I turn off the minimap button, with this version the button appears and clicking on it shows this weird cross: The Frame besides the char panel is empty: And this is the lua error messages I got from BugSack: 2x Interface\AddOns\Outfitter\OutfitterInventory.lua:845: attempt to index global 'C_Container' (a nil value) Locals: FindItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1001 ItemsByCode = } InventorySlotContainsItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1333 InventoryItems = } InheritOver = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:128 FindAllItems = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1120 Synchronize = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:799 ItemsBySlot = } GetMissingItems = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1178 SwapLocationWithInventorySlot = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:965 inherit = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:149 GetBoEItems = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1231 RemoveItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:911 FindItemInfoByCode = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:977 FindItemIndex = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1015 FindItemInfoBySlot = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:989 SwapBagSlotWithInventorySlot = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:973 SwapLocations = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:952 FlushBag = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1140 inheritOver = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:128 FlushInventory = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1151 CompiledUnusedItemsList = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1190 FirstBagIndex = 0 NumBags = 0 Flush = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:788 BagItems = } AddItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:869 ResetIgnoreItemFlags = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1170 ItemsAreSame = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1257 Inherit = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:149 NeedsUpdate = true FindItemOrAlt = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1091 Construct = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:775 FindAllItemsOrAlt = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1109 } vNumBags = 4 vFirstBagIndex = 0 (for index) = 0 (for limit) = 4 (for step) = 1 vBagIndex = 0 vBagItems = nil (*temporary) = nil (*temporary) = } (*temporary) = nil (*temporary) = JewelCode4 = 0 Gem2 = "" UpgradeID = 0 Code = 10725 Gem1 = "" SlotName = "Trinket1Slot" BonusIDs = "::" UpgradeTypeID = 0 EnchantCode = 0 Gem4 = "" Level = 46 Gem3 = "" Quality = 1 InstanceDifficultyID = 0 Type = "Trade Goods" InvType = "INVTYPE_TRINKET" Link = "|cffffffff|Hitem:10725::::::::52:::::::::|h[Gnomish Battle Chicken]|h|r" SubCode = 0 ItemSlotName = "Trinket0Slot" SubType = "Devices" JewelCode2 = 0 JewelCode1 = 0 Texture = 135996 Count = 1 JewelCode3 = 0 Location = } MinLevel = 0 UniqueID = 0 Name = "Gnomish Battle Chicken" } (*temporary) = 1 = } } (*temporary) = 1 = } 2 = } } (*temporary) = ChestSlot = } HandsSlot = } WristSlot = } Trinket1Slot = } ShoulderSlot = } Trinket0Slot = } MainHandSlot = } Finger0Slot = } NeckSlot = } BackSlot = } FeetSlot = } RangedSlot = } LegsSlot = } WaistSlot = } HeadSlot = } Finger1Slot = } } (*temporary) Edit: After creating a new outfit, the saved outfits appear. The outfits with automation fail to find their items like deep diving helmet or the carrot on a stick. 9x Interface\AddOns\Outfitter\OutfitterInventory.lua:845: attempt to index global 'C_Container' (a nil value) Locals: FindItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1001 ItemsByCode = } InventorySlotContainsItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1333 InventoryItems = } InheritOver = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:128 FindAllItems = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1120 Synchronize = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:799 ItemsBySlot = } GetMissingItems = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1178 SwapLocationWithInventorySlot = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:965 inherit = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:149 GetBoEItems = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1231 RemoveItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:911 FindItemInfoByCode = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:977 FindItemIndex = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1015 FindItemInfoBySlot = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:989 SwapBagSlotWithInventorySlot = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:973 SwapLocations = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:952 FlushBag = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1140 inheritOver = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:128 FlushInventory = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1151 CompiledUnusedItemsList = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1190 FirstBagIndex = 0 NumBags = 0 Flush = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:788 BagItems = } AddItem = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:869 ResetIgnoreItemFlags = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1170 ItemsAreSame = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1257 Inherit = defined @interface\AddOns\Outfitter\Libraries/MC2AddonLib/MC2AddonLib.lua:149 NeedsUpdate = true FindItemOrAlt = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1091 Construct = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:775 FindAllItemsOrAlt = defined @interface\AddOns\Outfitter\OutfitterInventory.lua:1109 } vNumBags = 4 vFirstBagIndex = 0 (for index) = 0 (for limit) = 4 (for step) = 1 vBagIndex = 0 vBagItems = nil (*temporary) = nil (*temporary) = } (*temporary) = nil (*temporary) = JewelCode4 = 0 Gem2 = "" UpgradeID = 0 Code = 10725 Gem1 = "" SlotName = "Trinket1Slot" BonusIDs = "::" UpgradeTypeID = 0 EnchantCode = 0 Gem4 = "" Level = 46 Gem3 = "" Quality = 1 InstanceDifficultyID = 0 Type = "Trade Goods" InvType = "INVTYPE_TRINKET" Link = "|cffffffff|Hitem:10725::::::::52:::::::::|h[Gnomish Battle Chicken]|h|r" SubCode = 0 ItemSlotName = "Trinket0Slot" SubType = "Devices" JewelCode2 = 0 JewelCode1 = 0 Texture = 135996 Count = 1 JewelCode3 = 0 Location = } MinLevel = 0 UniqueID = 0 Name = "Gnomish Battle Chicken" } (*temporary) = 1 = } } (*temporary) = 1 = } 2 = } } (*temporary) = ChestSlot = } HandsSlot = } WristSlot = } Trinket1Slot = } ShoulderSlot = } Trinket0Slot = } MainHandSlot = } Finger0Slot = } NeckSlot = } BackSlot = } FeetSlot = } RangedSlot = } LegsSlot = } WaistSlot = } HeadSlot = } Finger1Slot = } } (*temporary) |
Thanks for the errors. I think I didn't get a clean version when switching. I'll make sure I get it updated soon. |
Looks like I had some issues creating the packages. Both the vanilla namespace fix and the equipment manager fix used the main branch instead of the respective correct branches. @DeTosc Release 3.0.4.6.5 should work now (I made sure to make a clean directory and test this time). I really do appreciate the help making it right before I release it. |
No worries, I am glad to help. |
Is there someone that could help me get this working? I can't seem to figure it out and I need my Outfitter. :( Thanks. |
@Drockzoids Which errors are you getting? Have you tried the release on my fork for 3.0.4.6.5? |
I can confirm that this version is working for me woth Classic 1.14.3: https://github.com/GovtGeek/Outfitter/releases/tag/3.0.4.6.4 I was having the same problem as [DeTosc] witth the other versions. Just for info, version still shows as 3.0.4. It is strange because version in CourseForge says last version is 1.3.2: https://www.curseforge.com/wow/addons/outfitter-classic Thanks. |
Works well, thank you for fork! |
Hello! I love your add-on and have been using it since the beginning of classic <3. I'm currently playing on classic era but I keep getting an issue - I can customize and set up "Birthday Suit" and one more outfit but im unable to make more than those 2. Any chance you know what I could do to fix it? Date: 2023-07-31 19:16:34 AddOns: |
See if #152 fixes it |
Classic Era is 1.14.3. This addon claims to be Classic Era compatible. The errors seem to indicate otherwise. I know some errors might be expected due to people requesting Wrath, but would be nice to know status. I'll try downloading Wrath version and see if file lave just is wrongly indicating.
The text was updated successfully, but these errors were encountered: