You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found and figured out fixes for a couple of Icon selection bugs in the OutfitterBar.lua file:
Changed line 1226 to: if iconID and not usedIconIDs[iconID] then
Seems that iconID can be 'nil' from the call the GetProfessionInfo and when you pick drop down for your own spellbook you get a error on line 1228, where it attempts to add it to usedIconIDs table.
Also changed lines 1313 to 1315 to: for vBagSlotIndex = 1, vNumBagSlots do local itemInfo = C_Container.GetContainerItemInfo(vBagIndex, vBagSlotIndex) local vTexture = itemInfo and itemInfo.iconFileID
This relates to an error when you select to pick icons from your own bags.
The for loop was using 'vSlotIndex' but the name in the call to GetContainerItemInfo said 'vBagSlotIndex', so chose the latter.
The global 'C_Container' had a typo and said 'C_Containeer'
Empty bag slots return 'nil' so added a check to prevent itemInfo.iconFileID failing. vTexture is tested for 'nil' later so it's fine if it becomes nil itself.
Either of these errors can be seen by going to the Change Icon option on any outfit and changing the drop down to filter the list.
Hope this helps.
The text was updated successfully, but these errors were encountered:
Elesario
added a commit
to Elesario/Outfitter
that referenced
this issue
Jun 12, 2023
Both the change icon options to filter for your own spellbook and your bags cause errors currently in WotLK classic. Determined cause and added fixes. Also have logged issue as "WotLK Outfitter Icon selection bugs. cdmichaelb#143"
Found and figured out fixes for a couple of Icon selection bugs in the OutfitterBar.lua file:
Changed line 1226 to:
if iconID and not usedIconIDs[iconID] then
Seems that iconID can be 'nil' from the call the GetProfessionInfo and when you pick drop down for your own spellbook you get a error on line 1228, where it attempts to add it to usedIconIDs table.
Also changed lines 1313 to 1315 to:
for vBagSlotIndex = 1, vNumBagSlots do local itemInfo = C_Container.GetContainerItemInfo(vBagIndex, vBagSlotIndex) local vTexture = itemInfo and itemInfo.iconFileID
This relates to an error when you select to pick icons from your own bags.
Either of these errors can be seen by going to the Change Icon option on any outfit and changing the drop down to filter the list.
Hope this helps.
The text was updated successfully, but these errors were encountered: