Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WotLK Outfitter Icon selection bugs. #143

Open
Elesario opened this issue Jun 12, 2023 · 1 comment
Open

WotLK Outfitter Icon selection bugs. #143

Elesario opened this issue Jun 12, 2023 · 1 comment

Comments

@Elesario
Copy link
Contributor

Found and figured out fixes for a couple of Icon selection bugs in the OutfitterBar.lua file:

Changed line 1226 to:
if iconID and not usedIconIDs[iconID] then

Seems that iconID can be 'nil' from the call the GetProfessionInfo and when you pick drop down for your own spellbook you get a error on line 1228, where it attempts to add it to usedIconIDs table.

Also changed lines 1313 to 1315 to:
for vBagSlotIndex = 1, vNumBagSlots do local itemInfo = C_Container.GetContainerItemInfo(vBagIndex, vBagSlotIndex) local vTexture = itemInfo and itemInfo.iconFileID

This relates to an error when you select to pick icons from your own bags.

  • The for loop was using 'vSlotIndex' but the name in the call to GetContainerItemInfo said 'vBagSlotIndex', so chose the latter.
  • The global 'C_Container' had a typo and said 'C_Containeer'
  • Empty bag slots return 'nil' so added a check to prevent itemInfo.iconFileID failing. vTexture is tested for 'nil' later so it's fine if it becomes nil itself.

Either of these errors can be seen by going to the Change Icon option on any outfit and changing the drop down to filter the list.
Hope this helps.

Elesario added a commit to Elesario/Outfitter that referenced this issue Jun 12, 2023
Both the change icon options to filter for your own spellbook and your bags cause errors currently in WotLK classic. Determined cause and added fixes. Also have logged issue as "WotLK Outfitter Icon selection bugs. cdmichaelb#143"
@Elesario
Copy link
Contributor Author

Figured as this is git I should be able to submit a request with the changes I referenced. Hope didn't step on any toes. Thanks for the great addon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant