Outfitter is not working for Classic patch 1.14.4

[hoax89]

Hi,

Outfitter doesn't seem to work for the newest Classic Era & Classic Hardcore patch (1.14.4). I can see the Outfitter icon in the character panel, and extend or collapse the Outfitter frame, but I'm unable to create new outfits (nothing is happening when I'm clicking on the "New Outfit" button.

Steps to reproduce:

1. Open character panel in classic era / hc
2. Extend outfitter frame by clicking on the robe icon (this already produces an error, see below)
3. Select the "Outfitter" tab
4. Click on "New Outfit" (this produces an error, see below)
5. Observe how nothing happens

Error from step 2 (extending outfitter frame):

61x SharedXML/SharedUIPanelTemplates.lua:323: 'for' limit must be a number
[string "@SharedXML/SharedUIPanelTemplates.lua"]:323: in function `PanelTemplates_UpdateTabs'
[string "@SharedXML/SharedUIPanelTemplates.lua"]:309: in function `PanelTemplates_SetTab'
[string "@Outfitter/Outfitter.lua"]:1954: in function `ShowPanel'
[string "@Outfitter/Outfitter.lua"]:1197: in function `OnShow'
[string "*Outfitter.xml:1054_OnShow"]:1: in function <[string "*Outfitter.xml:1054_OnShow"]:1>
[string "=[C]"]: in function `Show'
[string "@Outfitter/Outfitter.lua"]:1180: in function `ToggleOutfitterFrame'
[string "*Outfitter.xml:592_OnClick"]:1: in function <[string "*Outfitter.xml:592_OnClick"]:1>

Locals:
frame = OutfitterFrame {
 0 = <userdata>
 TextureUsedHeight2 = 183
 TopMargin = 13
 TopHeight = 80
 TextureWidth1 = 256
 LeftMargin = 0
 RightWidth = 94
 TexCoordY1 = 0.312500
 TextureWidth2 = 128
 selectedTab = 1
 TextureHeight2 = 256
 Background = <table> {
 }
 TexCoordY3 = 0.714844
 TexCoordX2 = 0
 TexCoordY2 = 0
 TextureHeight1 = 256
 TexCoordX3 = 0.734375
 MiddleWidth2 = 60
 TexCoordX1 = 0.312500
 TextureUsedWidth2 = 94
 RightMargin = 1
 MiddleWidth1 = 176
 LeftWidth = 80
 BottomMargin = 3
 BottomHeight = 183
}
tab = nil
(for index) = 1
(for limit) = nil
(for step) = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "'for' limit must be a number"
GetTabByIndex = <function> defined @SharedXML/SharedUIPanelTemplates.lua:316

Error from step 4 (clicking on the "New Outfit" button):

17x ...tter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:165: attempt to call method 'SetBackdrop' (a nil value)
[string "@Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:165: in function `SetDialogBackdrop'
[string "@Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:188: in function `Construct'
[string "@Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua"]:145: in function `inheritOver'
[string "@Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua"]:41: in function `initObject'
[string "@Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua"]:15: in function <...dOns/Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:6>
[string "=(tail call)"]: ?
[string "@Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua"]:10: in function `New'
[string "@Outfitter/Outfitter.lua"]:3826: in function `OpenNameOutfitDialog'
[string "@Outfitter/Outfitter.lua"]:3839: in function `CreateNewOutfit'
[string "*Outfitter.xml:799_OnClick"]:2: in function <[string "*Outfitter.xml:799_OnClick"]:1>

Locals:
self = <table> {
 SetDialogBackdrop = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:163
 _PlainBorderedFrame = <table> {
 }
 _CloseButton = <table> {
 }
 _ScrollingList = <table> {
 }
 EndDialog = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:32
 _Window = <table> {
 }
 _ScrollingItemList = <table> {
 }
 Addon = <table> {
 }
 _FadingTitleBar = <table> {
 }
 _ExpandAllButton = <table> {
 }
 _Scrollbar = <table> {
 }
 BeginDialog = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:21
 _DropDownMenu = <table> {
 }
 _ExpandButton = <table> {
 }
 _PanelSectionBackgroundInfo = <table> {
 }
 _PowerDot = <table> {
 }
 _PushButton = <table> {
 }
 _PowerDots = <table> {
 }
 _ProgressBar = <table> {
 }
 _ScrollingEditBox = <table> {
 }
 _PortaitWindow = <table> {
 }
 _DropDownMenuItems = <table> {
 }
 _TitledDropDownMenuButton = <table> {
 }
 _Tabs = <table> {
 }
 _TimePicker = <table> {
 }
 _DropDownMenuButton = <table> {
 }
 _DatePicker = <table> {
 }
 _ModalDialogFrame = <table> {
 }
 _StretchTextures = <table> {
 }
 _TabbedView = <table> {
 }
 _Section = <table> {
 }
 _CheckButton = <table> {
 }
 _ScrollbarTrench = <table> {
 }
 _SidebarWindowFrame = <table> {
 }
 Version = 1
 _FloatingWindow = <table> {
 }
 _ContextMenu = <table> {
 }
 _LevelRangePicker = <table> {
 }
 _EditBox = <table> {
 }
 StaticPopup_EscapePressed = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:43
}
pFrame = Frame {
 0 = <userdata>
 inheritOver = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:128
 Inherit = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:149
 InheritOver = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:128
 inherit = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:149
 Construct = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:187
 New = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:183
}
(*temporary) = nil
(*temporary) = Frame {
 0 = <userdata>
 inheritOver = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:128
 Inherit = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:149
 InheritOver = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:128
 inherit = <function> defined @Outfitter/Libraries/MC2AddonLib/MC2AddonLib.lua:149
 Construct = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:187
 New = <function> defined @Outfitter/Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:183
}
(*temporary) = <table> {
 bgFile = "Interface\RAIDFRAME\UI-RaidFrame-GroupBg"
 tileSize = 512
 edgeFile = "Interface\DialogFrame\UI-DialogBox-Border"
 tile = true
 edgeSize = 32
 insets = <table> {
 }
}
(*temporary) = "attempt to call method 'SetBackdrop' (a nil value)"

[lierox90]

From what i was able to find Classic Era no longer uses Vanilla syntax for calling methods, but rather Wotlk/Mainline one.
According to: https://wowpedia.fandom.com/wiki/Global_functions/Classic
Vanilla: GetContainerNumSlots
Wotlk/Mainline: C_Container.GetContainerNumSlots

[nezorflame]

@hoax89 @lierox90 see if #152 fixes it

[MrBramwell]

@hoax89 @lierox90 see if #152 fixes it

I downloaded the WOTLK classic version and did the edits from this commit, seems to be working now in Classic Era - Only caveat I found is that the minimap button doesn't recognize the size or shape of the minimap (Im using a bigger square as my minimap.. however shiftclicking and moving the icon works)