Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message misleading when protect file contains @ #32

Open
moberghammer opened this issue Oct 30, 2020 · 1 comment
Open

Error message misleading when protect file contains @ #32

moberghammer opened this issue Oct 30, 2020 · 1 comment

Comments

@moberghammer
Copy link
Member

If a protect file is empty ( not containing a \r ) the following error is given:
failed to parse /zfs/cleaner_plans/cleaner_data_plan.conf: protected snapshot name include path

@abrander
Copy link
Contributor

I'm unable to reproduce. I tried the following:

abrander@abk-desktop:~/src/github.com/cego/zfs-cleaner$ cat > test.conf
plan test {
	path a
	protect <p
}
abrander@abk-desktop:~/src/github.com/cego/zfs-cleaner$ touch p
abrander@abk-desktop:~/src/github.com/cego/zfs-cleaner$ ./zfs-cleaner test.conf 
abrander@abk-desktop:~/src/github.com/cego/zfs-cleaner$ 

How can this we reproduced?

@moberghammer moberghammer changed the title Empty protect file fails config parse Error message misleading when protect file contains @ Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants