Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity tasks for pallet-anchors #1763

Open
lemunozm opened this issue Mar 7, 2024 · 0 comments
Open

Sanity tasks for pallet-anchors #1763

lemunozm opened this issue Mar 7, 2024 · 0 comments
Labels
crcl-protocol Circle protocol related. I11-cleaning No mandatory issue that leave the repo more readable/organized P0-someday-maybe Issue might be worth doing someday. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.

Comments

@lemunozm
Copy link
Contributor

lemunozm commented Mar 7, 2024

Description

Currently, pallet-anchors have some minor undesired issues:

  • 4 tests are ignored when they should have been enabled.
  • Some unsafe arithmetics
  • It uses pallet-aura in testing/benchmarks when it shouldn't use it, adding unneeded complexity.
@lemunozm lemunozm added Q3-medium Can be done with good experience in the language, but little knowledge of the codebase. P0-someday-maybe Issue might be worth doing someday. crcl-protocol Circle protocol related. I11-cleaning No mandatory issue that leave the repo more readable/organized labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crcl-protocol Circle protocol related. I11-cleaning No mandatory issue that leave the repo more readable/organized P0-someday-maybe Issue might be worth doing someday. Q3-medium Can be done with good experience in the language, but little knowledge of the codebase.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemunozm