This repository has been archived by the owner on May 24, 2024. It is now read-only.
Fixed broken hyperlinks in carbon-graphs README #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
added
documentation
sdadn
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
packages/carbon-graphs/README.md
Outdated
| - [Bubble](../terra-docs/docs/controls/Bubble.md#usage) | ||
| - [Bubble Single Dataset](../terra-docs/docs/controls/BubbleSingleDataset.md) | ||
| - [Bubble Multiple Dataset](../terra-docs/docs/controls/BubbleMultipleDataset.md) | ||
| - [Line](../terra-graphs-docs/docs/controls/Line.md#usage) |
There was a problem hiding this comment.
Looks like these links are not working as expected.
There was a problem hiding this comment.
They should be working on GitHub. If you select Rich Text Difference and try the links, they should work.
There was a problem hiding this comment.
Even in local, it dosen't look good
There was a problem hiding this comment.
This is also happening in other .md files that weren't updated so I think it's a rendering issue. Either way, it's beyond the scope of this story.
tbiethman
approved these changes
Aug 11, 2021
benbcai
approved these changes
Aug 13, 2021
AshishMotanamGurunadham
approved these changes
Aug 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #198
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon