This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updated Bar graphs example datasets and reflow logic to maintain consistency #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
| @@ -4,7 +4,7 @@ import DataObject from '@cerner/terra-graphs-docs/lib/example-datasets/dataObjec | |||
| require('details-polyfill') | |||
There was a problem hiding this comment.
Looks like you used different data object in example.
|
Change getting started and usage in doc.MDX files from terra-graphs to carbon-graphs. |
tbiethman
reviewed
Aug 16, 2021
| // <div id="tooltip" className="initial-tooltip" /> | ||
| // <BarGraph graphID="simpleBargraph" graphConfig={graphConfig} dataset={dataset} /> | ||
| // </React.Fragment> | ||
| // ); |
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-201-wzxocon
added 2 commits
September 28, 2021 12:58
ryanthemanuel
had a problem deploying
to
terra-graphs-issue-201-wzxocon
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-201-wzxocon
benbcai
reviewed
Oct 11, 2021
...docs/src/terra-dev-site/doc/Graphs/BarGraph/BasicBarGraphs/TimeseriesWithEventline.4.doc.mdx
Outdated
Show resolved
Hide resolved
benbcai
reviewed
Oct 11, 2021
| #### Dataset 4 | ||
| <DataObject2 /> | ||
|
|
||
| #### Dataset 5 |
There was a problem hiding this comment.
Should these be Datasets 2 and 3 instead of 4 and 5?
benbcai
reviewed
Oct 11, 2021
| <DataObject1 /> | ||
|
|
||
| #### Updated Data | ||
| <DataObject1 /> |
There was a problem hiding this comment.
Should this be DataObject2?
…aph/BasicBarGraphs/TimeseriesWithEventline.4.doc.mdx Co-authored-by: Ben Cai <[email protected]>
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-201-wzxocon
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-201-wzxocon
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-201-wzxocon
benbcai
approved these changes
Oct 11, 2021
tbiethman
approved these changes
Oct 11, 2021
ryanthemanuel
approved these changes
Oct 11, 2021
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-201-wzxocon
AshishMotanamGurunadham
approved these changes
Oct 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #201
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon