This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updated Bubble datasets and examples to maintain consistency #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshishMotanamGurunadham
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
sdadn
reviewed
Sep 10, 2021
| @@ -2,28 +2,29 @@ import { loadBubblePopup } from '@cerner/terra-graphs-docs/lib/example-datasets/ | |||
| import Carbon from '@cerner/carbon-graphs/lib/js/carbon'; | |||
|
|
|||
| const bubbleDataBasic = { | |||
| key: 'uid_1', | |||
| key: 'Bubble_Basic_Data', | |||
There was a problem hiding this comment.
nit: don't combine caps and underscore; make it all lower case
There was a problem hiding this comment.
Fixed here.
AshishMotanamGurunadham
force-pushed
the
issue-206
branch
from
84cfa53 to
41ce502
Compare
sdadn
approved these changes
Sep 13, 2021
ryanthemanuel
approved these changes
Sep 13, 2021
tbiethman
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #206
Jira Link: https://jira2.cerner.com/browse/UXPLATFORM-5484
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon