This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updated Combination graph datasets and examples to maintain consistency. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshishMotanamGurunadham
requested review from
mjhenkes,
ryanthemanuel and
tbiethman
as code owners
AshishMotanamGurunadham
force-pushed
the
issue-207
branch
from
4b3a1ab to
401809b
Compare
|
Please rebase with main and resolve conflicts |
sdadn
reviewed
Sep 21, 2021
| @@ -0,0 +1,28 @@ | |||
| import Carbon from '@cerner/carbon-graphs/lib/js/carbon'; | |||
| import { | |||
| loadPopup, | |||
There was a problem hiding this comment.
nit: remove , to make it a single line
There was a problem hiding this comment.
Fixed here.
tbiethman
approved these changes
Sep 24, 2021
AshishMotanamGurunadham
force-pushed
the
issue-207
branch
from
7317e0e to
13555b9
Compare
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-207-lbehkf9
sdadn
reviewed
Sep 27, 2021
|
|
||
| const graphConfig = utils.deepClone(getCombinationGraphConfig('#lineWithMultipleBubbleData')); | ||
| const dataset = utils.deepClone(data); | ||
| const dataset = [utils.deepClone(multipleBubbleDataset1), utils.deepClone(multipleBubbleDataset2), utils.deepClone(lineDataset)]; |
There was a problem hiding this comment.
nit for easier reading:
Suggested change
| const dataset = [utils.deepClone(multipleBubbleDataset1), utils.deepClone(multipleBubbleDataset2), utils.deepClone(lineDataset)]; | |
| const dataset = [ | |
| utils.deepClone(multipleBubbleDataset1), | |
| utils.deepClone(multipleBubbleDataset2), | |
| utils.deepClone(lineDataset) | |
| ]; |
ryanthemanuel
approved these changes
Sep 27, 2021
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-207-lbehkf9
AshishMotanamGurunadham
force-pushed
the
issue-207
branch
from
e2fd26e to
29fdffa
Compare
ryanthemanuel
temporarily deployed
to
terra-graphs-issue-207-lbehkf9
sdadn
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #207
Deployment Link
https://terra-graphs-deployed-pr-#.herokuapp.com/
Thank you for contributing to Terra.
@cerner/terra
@cerner/carbon